ltp: support network tests configurations#95
Open
acerv wants to merge 1 commit intolinux-test-project:masterfrom
Open
ltp: support network tests configurations#95acerv wants to merge 1 commit intolinux-test-project:masterfrom
acerv wants to merge 1 commit intolinux-test-project:masterfrom
Conversation
Complete the supported environment variables which are currently supported by the network tests. Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> Fixes: linux-test-project#94
pevik
reviewed
Mar 18, 2026
| if key != "PATH" | ||
| } | ||
| # One representative per prefix is enough to verify prefix-based forwarding. | ||
| net_vars["TST_USE_NETNS"] = "yes" |
Member
There was a problem hiding this comment.
FYI This is not needed, it's a default.
pevik
reviewed
Mar 18, 2026
| } | ||
| # One representative per prefix is enough to verify prefix-based forwarding. | ||
| net_vars["TST_USE_NETNS"] = "yes" | ||
| net_vars["LTP_RSH"] = "ssh -nq" |
Member
There was a problem hiding this comment.
This is also the default. Having the definition on 2 places only ask for problems if tst_net.sh changes it, it will be overwritten in kirk.
Instead of definition of these two which is not needed it'd be great to evaluate what user sets and support 2 host setup (if user defines it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the supported environment variables which are currently supported by the network tests.
Signed-off-by: Andrea Cervesato andrea.cervesato@suse.com
Fixes: #94